----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69590/#review211424 -----------------------------------------------------------
Fix it, then Ship it! The commit message of this patch seems not accurate to me, we are not moving CNI root directory to a persistent location, we actually added a new agent flag for operator to specify whether persist the network related information or not. docs/cni.md Lines 106 (patched) <https://reviews.apache.org/r/69590/#comment296521> As Chun mentioned, please also mention this flag in `docs/upgrades.md`. docs/configuration/agent.md Lines 1184 (patched) <https://reviews.apache.org/r/69590/#comment296519> s/persist/persists/ src/slave/flags.cpp Lines 1190 (patched) <https://reviews.apache.org/r/69590/#comment296520> s/persist/persists/ And no need the leading space. - Qian Zhang On Dec. 19, 2018, 12:52 p.m., Deepak Goel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69590/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 12:52 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey > Urbanovich. > > > Bugs: MESOS-9492 > https://issues.apache.org/jira/browse/MESOS-9492 > > > Repository: mesos > > > Description > ------- > > This patch moves the CNI root directory to mesos working directory > so that the network related information persist across reboot which > will allow cni isolator to do proper cleanup post reboot > > > Diffs > ----- > > docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c > docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f19edce0671686bc2dccf5dc6d3abc40b925852e > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 3b06fb101d03b32a3a148e2b79502413a7268d1e > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > c1cb4f7d667159abbf87219cde30528a4a7b5283 > src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 > src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 > src/tests/containerizer/cni_isolator_tests.cpp > 5473737cdc71a3179c22be0d4db2060a6ef53d24 > > > Diff: https://reviews.apache.org/r/69590/diff/4/ > > > Testing > ------- > > > Thanks, > > Deepak Goel > >
