----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/#review211534 -----------------------------------------------------------
src/linux/seccomp/seccomp_parser.hpp Lines 22 (patched) <https://reviews.apache.org/r/68019/#comment296855> This is should be before `#include <stout/try.hpp>`. src/linux/seccomp/seccomp_parser.hpp Lines 30 (patched) <https://reviews.apache.org/r/68019/#comment296854> One more newline here. src/linux/seccomp/seccomp_parser.cpp Lines 39-40 (patched) <https://reviews.apache.org/r/68019/#comment296856> Can we change it to `constexpr char SCMP_PREFIX[] = "SCMP_`? src/linux/seccomp/seccomp_parser.cpp Lines 484 (patched) <https://reviews.apache.org/r/68019/#comment296860> Can you please elaborate on why we need to do the parsing manually rather than using `protobuf::parse`? Is it because we need to manually handle the `SCMP_` prefix? Any other reasons? src/linux/seccomp/seccomp_parser.cpp Lines 485 (patched) <https://reviews.apache.org/r/68019/#comment296858> Kill this newline, and ditto for the other two places below this code. src/linux/seccomp/seccomp_parser.cpp Lines 504 (patched) <https://reviews.apache.org/r/68019/#comment296857> Just a question, this will not affect agent process since we do not call `seccompFilter.get()->load()`, right? - Qian Zhang On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68019/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 11:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9105 > https://issues.apache.org/jira/browse/MESOS-9105 > > > Repository: mesos > > > Description > ------- > > Docker Seccomp config is a JSON file containing Seccomp filtering > rules. This patch introduces a parser for Docker Seccomp config format. > This parser accepts a JSON-string, parses and validates it, then > returns a prepared `ContainerSeccompProfile` message. > > > Diffs > ----- > > src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 > src/Makefile.am 2d9c81b149a5764dc82593bef102f5568847daa2 > src/linux/seccomp/seccomp_parser.hpp PRE-CREATION > src/linux/seccomp/seccomp_parser.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68019/diff/7/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
