----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/#review211947 -----------------------------------------------------------
Fix it, then Ship it! src/linux/seccomp/seccomp_parser.cpp Lines 87 (patched) <https://reviews.apache.org/r/68019/#comment297519> s/configuration /configuration/ Ditto for all other messages starting with `Cannot determine`. src/linux/seccomp/seccomp_parser.cpp Lines 160 (patched) <https://reviews.apache.org/r/68019/#comment297521> Kill this empty line. I see a couple of empty lines like this, please remove them as well. src/linux/seccomp/seccomp_parser.cpp Lines 216-217 (patched) <https://reviews.apache.org/r/68019/#comment297525> A newline between. src/linux/seccomp/seccomp_parser.cpp Lines 363-365 (patched) <https://reviews.apache.org/r/68019/#comment297527> So `includes` is a **required** field in a seccomp profile, at least we should have `"includes": {}` in a seccomp profile, right? src/linux/seccomp/seccomp_parser.cpp Lines 516 (patched) <https://reviews.apache.org/r/68019/#comment297518> s/Error reading/Failed to read/ And I think we do not need the word `file` in this message just like the message below. - Qian Zhang On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68019/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 11:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9105 > https://issues.apache.org/jira/browse/MESOS-9105 > > > Repository: mesos > > > Description > ------- > > Docker Seccomp config is a JSON file containing Seccomp filtering > rules. This patch introduces a parser for Docker Seccomp config format. > This parser accepts a JSON-string, parses and validates it, then > returns a prepared `ContainerSeccompProfile` message. > > > Diffs > ----- > > src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 > src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa > src/linux/seccomp/seccomp_parser.hpp PRE-CREATION > src/linux/seccomp/seccomp_parser.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68019/diff/13/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
