----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review211561 -----------------------------------------------------------
src/tests/containerizer/linux_seccomp_parser_tests.cpp Lines 26-27 (patched) <https://reviews.apache.org/r/69409/#comment296896> I do not think we need these, we can just use `ContainerSeccompProfile::Syscall`. src/tests/containerizer/linux_seccomp_parser_tests.cpp Lines 92 (patched) <https://reviews.apache.org/r/69409/#comment296897> We should check this field in the code below as well? src/tests/containerizer/linux_seccomp_parser_tests.cpp Lines 359 (patched) <https://reviews.apache.org/r/69409/#comment296898> Just a question, where do we check the name of the syscall? It seems there is no such error message in the patch https://reviews.apache.org/r/68019 - Qian Zhang On Nov. 20, 2018, 8:21 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69409/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 8:21 p.m.) > > > Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. > > > Bugs: MESOS-9392 > https://issues.apache.org/jira/browse/MESOS-9392 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa > src/tests/CMakeLists.txt c588183e9d2b1cc733fdf3df70f37d47a5fdd7c0 > src/tests/containerizer/linux_seccomp_parser_tests.cpp PRE-CREATION > src/tests/environment.cpp 03f8f5971b1e91e62ecfbf965028e6f2388d2a7b > > > Diff: https://reviews.apache.org/r/69409/diff/3/ > > > Testing > ------- > > ./src/mesos-tests > --gtest_filter=SeccompParserTest.SECCOMP_ParseInvalidSeccompProfile > --gtest_break_on_failure --gtest_repeat=100 --verbose > > > Thanks, > > Andrei Budnik > >
