----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ -----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9434 https://issues.apache.org/jira/browse/MESOS-9434 Repository: mesos Description ------- After a framework was removed and has unacknowledged operations status updates, it was impossible to remove terminal operations as nobody could acknowledge them. In this patch we make the master acknowledge operation status updates for frameworks it knows are removed so that e.g., terminal operations can be removed. Since masters do not persist completed frameworks this is not reliable (e.g., an agent was partitioned for a long time and still tracks a completed framework's `FrameworkInfo`, and comes back only after the master knowing about the framework's completion has failed over). We merely extend the existing master behavior (e.g., send `ShutdownFrameworkMessage` to all currently registered agents) to operations. Diffs ----- src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e Diff: https://reviews.apache.org/r/69680/diff/1/ Testing ------- * `make check` * tested on a number of configurations in internal CI * ran added test in repetition, both with and without additional stress Thanks, Benjamin Bannier