----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212486 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_tests.cpp Line 9331 (original), 9334 (patched) <https://reviews.apache.org/r/69680/#comment298246> s/for that// - Greg Mann On Jan. 29, 2019, 1:21 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69680/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 1:21 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-9434 > https://issues.apache.org/jira/browse/MESOS-9434 > > > Repository: mesos > > > Description > ------- > > After a framework was removed and has unacknowledged operations status > updates, it was impossible to remove terminal operations as nobody could > acknowledge them. > > In this patch we make the master acknowledge operation status updates > for frameworks it knows are removed so that e.g., terminal operations > can be removed. Since masters do not persist completed frameworks this > is not reliable (e.g., an agent was partitioned for a long time and > still tracks a completed framework's `FrameworkInfo`, and comes back > only after the master knowing about the framework's completion has > failed over). We merely extend the existing master behavior (e.g., send > `ShutdownFrameworkMessage` to all currently registered agents) to > operations. > > > Diffs > ----- > > src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915 > src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 > > > Diff: https://reviews.apache.org/r/69680/diff/2/ > > > Testing > ------- > > * `make check` > * tested on a number of configurations in internal CI > * ran added test in repetition, both with and without additional stress > > > Thanks, > > Benjamin Bannier > >
