----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/#review211957 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp Line 237 (original), 241 (patched) <https://reviews.apache.org/r/69720/#comment297536> This test doesn't need the parameterization. It can use the base class. 3rdparty/libprocess/src/tests/ssl_tests.cpp Line 266 (original), 270 (patched) <https://reviews.apache.org/r/69720/#comment297537> This one also doesn't need parameters. 3rdparty/libprocess/src/tests/ssl_tests.cpp Line 417 (original), 421 (patched) <https://reviews.apache.org/r/69720/#comment297538> You can consider moving this test up to group with the other parameterized tests. (Or moving those tests down) - Joseph Wu On Jan. 11, 2019, 3:22 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69720/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 3:22 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-5189 > https://issues.apache.org/jira/browse/MESOS-5189 > > > Repository: mesos > > > Description > ------- > > This general and reusable testing class is made unparameterized since > deriving from a parameterized test is cumbersome (e.g., requires manual > disambiguation of possibly private types and methods inherited from the > respective `::testing::WithParamInterface` base class). > > This patch makes `SSLTest` an unparameterized test suite which eases > reuse. We are able to remove a number of redundant test > parameterizations along the way. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 23d7aee963b6fb489403a94500d39e3413c7fcdd > 3rdparty/libprocess/src/tests/ssl_tests.cpp > bfb5eab255230b7fbfdefaa62be27a8f8c4e9517 > > > Diff: https://reviews.apache.org/r/69720/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
