-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/
-----------------------------------------------------------
(Updated Jan. 14, 2019, 8:54 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Addressed Joseph's comments.
Bugs: MESOS-5189
https://issues.apache.org/jira/browse/MESOS-5189
Repository: mesos
Description
-------
This general and reusable testing class is made unparameterized since
deriving from a parameterized test is cumbersome (e.g., requires manual
disambiguation of possibly private types and methods inherited from the
respective `::testing::WithParamInterface` base class).
This patch makes `SSLTest` an unparameterized test suite which eases
reuse. We are able to remove a number of redundant test
parameterizations along the way.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/gtest.hpp
23d7aee963b6fb489403a94500d39e3413c7fcdd
3rdparty/libprocess/src/tests/ssl_tests.cpp
bfb5eab255230b7fbfdefaa62be27a8f8c4e9517
Diff: https://reviews.apache.org/r/69720/diff/2/
Changes: https://reviews.apache.org/r/69720/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
