-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/
-----------------------------------------------------------
(Updated Jan. 15, 2019, 10:27 a.m.)
Review request for mesos, Chun-Hung Hsiao and James DeFelice.
Changes
-------
Addressed some comments from Chun.
Bugs: MESOS-9223
https://issues.apache.org/jira/browse/MESOS-9223
Repository: mesos
Description
-------
This patch adds monotonically increasing counters for subscriptions and
disconnections of resource providers with the resource provider manager
(`resource_provider_manager/subscriptions` and
`resource_provider_manager/disconnections`, respectively). While the
existing gauge `resource_provider_manager/subscribed` exposed the
current state, these added counters can be used to monitor resource
provider state for unexpected events.
Diffs (updated)
-----
src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
src/tests/resource_provider_manager_tests.cpp
455ce7d2c71f2815430b69a5475b2ccc343cd9af
Diff: https://reviews.apache.org/r/69719/diff/2/
Changes: https://reviews.apache.org/r/69719/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier