> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 823-832 (original), 827-836 (patched) > > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line827> > > > > How about moving this snippt to the end of this function, so the agent > > would receive `SUBSCRIBE` and then `DISCONNECT` no matter if the RP has a > > connection problem after it subscribes? This would also make the metric > > reveal the connection problem. > > Benjamin Bannier wrote: > This is supposed to be a counter for successful subscriptions, see below. > > Chun-Hung Hsiao wrote: > The problem I describe still remains. Moving the `return` statement > around could help us to capture the disconnection in the metrics. WDYT?
Makes sense, updated the patch. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211971 ----------------------------------------------------------- On Jan. 16, 2019, 12:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69719/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2019, 12:49 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and James DeFelice. > > > Bugs: MESOS-9223 > https://issues.apache.org/jira/browse/MESOS-9223 > > > Repository: mesos > > > Description > ------- > > This patch adds monotonically increasing counters for subscriptions and > disconnections of resource providers with the resource provider manager > (`resource_provider_manager/events/subscribed` and > `resource_provider_manager/events/disconnects`, respectively). While the > existing gauge `resource_provider_manager/subscribed` exposed the > current state, these added counters can be used to monitor resource > provider state for unexpected events. > > > Diffs > ----- > > src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac > src/tests/resource_provider_manager_tests.cpp > 455ce7d2c71f2815430b69a5475b2ccc343cd9af > > > Diff: https://reviews.apache.org/r/69719/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
