----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/#review212216 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/linux_seccomp_isolator_tests.cpp Lines 874 (patched) <https://reviews.apache.org/r/69420/#comment297930> Do we really need to add `SECCOMP_` for the tests in this patch? Will there be any problems when running these tests on non-x86_64 platforms? src/tests/containerizer/linux_seccomp_isolator_tests.cpp Lines 1028-1029 (patched) <https://reviews.apache.org/r/69420/#comment297931> To test the **overridden**, I think we need to specify a default profile as well, and there should be some conflicts between the default profile and the container's own profile, e.g., a syscall is allowed by the former but disallowed by the later, and launching a container to call that syscall, verify the container will fail. src/tests/containerizer/linux_seccomp_isolator_tests.cpp Lines 1168 (patched) <https://reviews.apache.org/r/69420/#comment297932> Should be `result`? - Qian Zhang On Nov. 28, 2018, 7:47 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69420/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2018, 7:47 p.m.) > > > Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. > > > Bugs: MESOS-9409 > https://issues.apache.org/jira/browse/MESOS-9409 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 > src/tests/CMakeLists.txt 7a1265e38e5e3b3a102862d231fc78adae14c4fe > src/tests/containerizer/linux_seccomp_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/69420/diff/7/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
