> On Jan. 23, 2019, 6:49 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_isolator_tests.cpp > > Lines 874 (patched) > > <https://reviews.apache.org/r/69420/diff/7/?file=2121292#file2121292line874> > > > > Do we really need to add `SECCOMP_` for the tests in this patch? Will > > there be any problems when running these tests on non-x86_64 platforms?
I don't think we need `SECCOMP_` for `MissingConfigDir` and `InvalidDefaultProfile` tests. All other tests depend on architecture. We don't want to have a long `archMap` specifying all supported architectures by `libseccomp` for configs in these tests. > On Jan. 23, 2019, 6:49 a.m., Qian Zhang wrote: > > src/tests/containerizer/linux_seccomp_isolator_tests.cpp > > Lines 1028-1029 (patched) > > <https://reviews.apache.org/r/69420/diff/7/?file=2121292#file2121292line1028> > > > > To test the **overridden**, I think we need to specify a default > > profile as well, and there should be some conflicts between the default > > profile and the container's own profile, e.g., a syscall is allowed by the > > former but disallowed by the later, and launching a container to call that > > syscall, verify the container will fail. Actually, we can override a non-specified default profile. I've added a non-empty default profile in this test. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69420/#review212216 ----------------------------------------------------------- On Nov. 28, 2018, 11:47 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69420/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2018, 11:47 a.m.) > > > Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. > > > Bugs: MESOS-9409 > https://issues.apache.org/jira/browse/MESOS-9409 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 > src/tests/CMakeLists.txt 7a1265e38e5e3b3a102862d231fc78adae14c4fe > src/tests/containerizer/linux_seccomp_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/69420/diff/8/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
