----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212419 -----------------------------------------------------------
I think you missed my top level comment from the last review to add context to the commit about the min allocatable flag and how this is providing a per-framework/role override of that global flag? Also, we're missing a patch for the master to allow changing the value upon framework re-registration? src/common/resource_quantities.cpp Lines 82-90 (patched) <https://reviews.apache.org/r/69818/#comment298185> Can we add some validation somewhere to ensure that negative value scalars are not provided? - Benjamin Mahler On Jan. 29, 2019, 4:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69818/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 4:24 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch adds new fields to `FrameworkInfo` which can be used by > frameworks to configure static, per-role resource requirements. We > currently support specifying minimal allocatable resources which can > e.g., be interpreted by allocators to filter out resources not relevant > to frameworks, or make allocations below globally configured minimal > allocatable resources for particular frameworks. > > > Diffs > ----- > > include/mesos/mesos.proto 3477b7db4dc64187aa55e8e4feb66a62f7951429 > include/mesos/v1/mesos.proto 692940bc862e61b9899aa159f29b662f3aade033 > src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd > src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f > > > Diff: https://reviews.apache.org/r/69818/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
