----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212488 -----------------------------------------------------------
src/master/framework.cpp Lines 504 (patched) <https://reviews.apache.org/r/69818/#comment298248> Can you guard this with a has check? As it stands it will produce a different message if newInfo has it unset (info will have it set vs newInfo has it not set) - Benjamin Mahler On Jan. 31, 2019, 3:29 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69818/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2019, 3:29 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch adds a new field to `FrameworkInfo` which can be used by > frameworks to configure static, per-role resource requirements. We > currently support specifying minimal allocatable resources which can > e.g., be interpreted by allocators to filter out resources not relevant > to frameworks, or make allocations below globally configured minimal > allocatable resources for particular frameworks. > > We use a new message `ResourceQuantities` to specify resource > requirements. This class is modelled after the internal class of the > same name, and we provide a conversion from the API to the internal > type. > > > Diffs > ----- > > include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 > include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed > src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd > src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f > src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 > > > Diff: https://reviews.apache.org/r/69818/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
