----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212456 -----------------------------------------------------------
PASS: Mesos patch 69821 was successfully built and tested. Reviews applied: `['69861', '69818', '69862', '69821']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2833/mesos-review-69821 - Mesos Reviewbot Windows On Jan. 30, 2019, 4:08 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69821/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2019, 4:08 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch modifies the hierarchical allocator to take > framework-specified minimal allocatable resources into account. > > While previously the allocator was inspecting the minimal allocatable > resources specified in its options, it now inspects a dynamically > calculated set of minimal allocatable resources. This set is populated > with any minimal allocatable resources specified in the allocator's > options and any framework's minimal allocatable resources. For a > resource to be allocatable it needs to contain any of these minimal > requirements. > > If a framework does not specify minimal allocatable resource > requirements, its minimal requirements are set to the globally > configured option. > > We also adjust the allocator to take a framework's minimal resource > requirements into account when checking whether a resource can be > allocated to a particular framework. The check is performed at the same > time we check whether a framework filtered a particular resource. This > avoids offering resources to frameworks which the framework would never > have considered allocatable itself (e.g., given the global option of the > allocator). > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > ca1638390d89e2a81efd9d6d4a28b863c79723c4 > src/master/allocator/mesos/hierarchical.cpp > f1f3894058a8e3f008013cb269744bd36c0e31b3 > src/tests/hierarchical_allocator_tests.cpp > cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee > > > Diff: https://reviews.apache.org/r/69821/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
