----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212516 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['69818', '69862', '69821']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2844/mesos-review-69821 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2844/mesos-review-69821/logs/mesos-tests.log): ``` W0204 12:23:02.096771 32304 slave.cpp:3934] Ignoring shutdown framework 549ca5ea-b22e-492b-a25d-34e375705140-0000 because it is terminating I0204 12:23:02.098772 29556 master.cpp:1269] Agent 549ca5ea-b22e-492b-a25d-34e375705140-S0 at slave(477)@192.10.1.6:64813 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected I0204 12:23:02.098772 29556 master.cpp:3272] Disconnecting agent 549ca5ea-b22e-492b-a25d-34e375705140-S0 at slave(477)@192.10.1.6:64813 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0204 12:23:02.099773 29556 master.cpp:3291] Deactivating agent 549ca5ea-b22e-492b-a25d-34e375705140-S0 at slave(477)@192.10.1.6:64813 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0204 12:23:02.099773 23200 hierarchical.cpp:395] Removed framework 549ca5ea-b22e-492b-a25d-34e375705140-0000 I0204 12:23:02.099773 23200 hierarchical.cpp:830] Agent 549ca5ea-b22e-492b-a25d-34e375705140-S0 deactivated I0204 12:23:02.100780 23200 containerizer.cpp:2477] Destroying container e4bb3083-bbec-4218-875e-29d9d952976e in RUNNING state I0204 12:23:02.100780 23200 containerizer.cpp:3144] Transitioning the state of container e4bb3083-bbec-4218-875e-29d9d952976e from RUNNING to DESTROYING I0204 12:23:02.101773 23200 launcher.cpp:161] Asked to destroy container e4bb3083-bbec-4218-875e-29d9d952976e W0204 12:23:02.102820 32144 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=12116 to peer '192.10.1.6:50327': IO failed with error code: The specified network name is no longer available. W0204 12:23:02.102820 32144 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11820 to peer '192.10.1.6:50326': IO failed with error code: The specified network name is no longer available. I0204 12:23:02.188532 29556 containerizer.cpp:2983] Container e4bb3083-bbec-4218-875e-29d9d952976e has exited I0204 12:23:02.217483 26532 master.cpp:1109] Ma[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (682 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (698 ms total) [----------] Global test environment tear-down [==========] 1099 tests from 104 test cases ran. (500835 ms total) [ PASSED ] 1098 tests. [ FAILED ] 1 test, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage 1 FAILED TEST YOU HAVE 231 DISABLED TESTS ster terminating I0204 12:23:02.219491 20272 hierarchical.cpp:681] Removed agent 549ca5ea-b22e-492b-a25d-34e375705140-S0 I0204 12:23:02.628484 32144 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On Feb. 4, 2019, 11:14 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69821/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2019, 11:14 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch modifies the hierarchical allocator to take > framework-specified minimal allocatable resources into account. > > While previously the allocator was inspecting the minimal allocatable > resources specified in its global options, it can now also inspects > framework-specific resource requirements. With that frameworks can e.g., > configure resource requirements above the default minimal allocatable > resource, or opt into receiving resources considered too small to be > allocatable by the allocator in its default behavior. > > For that we change the hierarchical allocator's `allocatable` function > to be framework and role-specific. As that does in some places not allow > us to abort iterating over candidate resource consumers like before an > additional check on whether any resources are left in an allocation > cycle is added as a break condition. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 1420c2638786d85f7b04379e5d79e59990c3e6cf > src/master/allocator/mesos/hierarchical.cpp > bb9a9c95979f36c0564af5b3babb1c43077a363b > src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 > src/tests/hierarchical_allocator_tests.cpp > cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee > > > Diff: https://reviews.apache.org/r/69821/diff/5/ > > > Testing > ------- > > `make check` > > > File Attachments > ---------------- > > Ratio new/old timings > > https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png > > > Thanks, > > Benjamin Bannier > >
