-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69821/
-----------------------------------------------------------
(Updated Feb. 5, 2019, 5:38 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Adress a couple issues raised by Ben
Bugs: MESOS-9523
https://issues.apache.org/jira/browse/MESOS-9523
Repository: mesos
Description
-------
This patch modifies the hierarchical allocator to take
framework-specified minimal allocatable resources into account.
While previously the allocator was inspecting the minimal allocatable
resources specified in its global options, it can now also inspects
framework-specific resource requirements. With that frameworks can e.g.,
configure resource requirements above the default minimal allocatable
resource, or opt into receiving resources considered too small to be
allocatable by the allocator in its default behavior.
For that we change the hierarchical allocator's `allocatable` function
to be framework and role-specific. As that does in some places not allow
us to abort iterating over candidate resource consumers like before an
additional check on whether any resources are left in an allocation
cycle is added as a break condition.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp
1420c2638786d85f7b04379e5d79e59990c3e6cf
src/master/allocator/mesos/hierarchical.cpp
bb9a9c95979f36c0564af5b3babb1c43077a363b
Diff: https://reviews.apache.org/r/69821/diff/8/
Changes: https://reviews.apache.org/r/69821/diff/7-8/
Testing
-------
`make check`
File Attachments
----------------
Ratio new/old timings
https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png
Thanks,
Benjamin Bannier
