----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212632 -----------------------------------------------------------
Fix it, then Ship it! src/tests/operation_reconciliation_tests.cpp Lines 945 (patched) <https://reviews.apache.org/r/69911/#comment298456> Use `GetParam()` here? src/tests/operation_reconciliation_tests.cpp Lines 984-985 (patched) <https://reviews.apache.org/r/69911/#comment298457> Let's also expect that the resource provider ID is unset in the update. src/tests/operation_reconciliation_tests.cpp Lines 987 (patched) <https://reviews.apache.org/r/69911/#comment298458> Period at the end of comment, here and elsewhere. - Greg Mann On Feb. 6, 2019, 9:02 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69911/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2019, 9:02 p.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9473 > https://issues.apache.org/jira/browse/MESOS-9473 > > > Repository: mesos > > > Description > ------- > > Added tests for reconciliation of operations on agent default resources. > > > Diffs > ----- > > src/tests/operation_reconciliation_tests.cpp > 9a1fc95752c8ce7c7358561bda3659a76871f5c3 > > > Diff: https://reviews.apache.org/r/69911/diff/1/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" > --gtest_repeat=5000 --gtest_break_on_failure` passed > > > Thanks, > > Gastón Kleiman > >
