> On Feb. 7, 2019, 4:36 p.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1383 (patched) > > <https://reviews.apache.org/r/69911/diff/2/?file=2124482#file2124482line1383> > > > > Could you explain in this comment why the response contains no > > operations?
Good catch! I swear I had added this, but it either got lost when squashing the commits or I'm starting to imagine things ;-). - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212654 ----------------------------------------------------------- On Feb. 8, 2019, 3:12 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69911/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2019, 3:12 p.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9473 > https://issues.apache.org/jira/browse/MESOS-9473 > > > Repository: mesos > > > Description > ------- > > Added tests for reconciliation of operations on agent default resources. > > > Diffs > ----- > > src/tests/operation_reconciliation_tests.cpp > 9a1fc95752c8ce7c7358561bda3659a76871f5c3 > > > Diff: https://reviews.apache.org/r/69911/diff/3/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" > --gtest_repeat=5000 --gtest_break_on_failure` passed > > > Thanks, > > Gastón Kleiman > >
