----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review213083 -----------------------------------------------------------
Patch looks great! Reviews applied: [67185] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Dec. 6, 2018, 1:28 a.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67185/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2018, 1:28 a.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao > Li. > > > Repository: mesos > > > Description > ------- > > This change adds the method `Resource.request_protobuf()` which assumes > that both the request and response data are encoded in protobuf. This > will be used later in the RPC client, which will also include a decoding > step. > > Testing Done: > Ran unit tests with `tox` under `src/python/lib` > > > Diffs > ----- > > src/python/lib/mesos/constants.py PRE-CREATION > src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd > src/python/lib/requirements.in 86ee2ad40c0c114b0082f2d4f52f75758d41cbd9 > src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab > > > Diff: https://reviews.apache.org/r/67185/diff/5/ > > > Testing > ------- > > > Thanks, > > Eric Chung > >
