> On March 4, 2019, 10:20 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 2261 (patched) > > <https://reviews.apache.org/r/70116/diff/1/?file=2128636#file2128636line2263> > > > > Why not use `updateOperationMetrics(OPERATION_ERROR, 1);` here?
Why not, indeed. > On March 4, 2019, 10:20 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 9223-9224 (patched) > > <https://reviews.apache.org/r/70116/diff/1/?file=2128636#file2128636line9225> > > > > s/agent/master/ > > > > Yea I think we can crash here. I though about this some more, and I'm actually leaning towards the opposite conclusion: Left like this, the worst case outcome is that we'll miss a bug that result in incorrect counter values being displayed. When we crash, the worst case is that a bug in the metrics accounting code might lead to a unrecoverable, crash-looping master. So I think avoiding the latter scenario might be worth departing from the precedence here, especially since we already have precedence for masters actually failing to start for "non-critical" reasons. I'm not insisting, though, if you still think having a `CHECK()` would be better I'm happy to add it. (the same comment applies almost verbatim to the `CHECK()` suggested by Gaston below as well) - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213404 ----------------------------------------------------------- On March 8, 2019, 11:48 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70116/ > ----------------------------------------------------------- > > (Updated March 8, 2019, 11:48 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8241 > https://issues.apache.org/jira/browse/MESOS-8241 > > > Repository: mesos > > > Description > ------- > > This commit adds additional metrics counting the > number of operations in each state. > > Unit tests are added in the subsequent commit. > > > Diffs > ----- > > src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce > src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa > src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 > > > Diff: https://reviews.apache.org/r/70116/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
