asekretenko commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268592665
########## File path: 3rdparty/Makefile.am ########## @@ -248,8 +248,17 @@ $(LIB_GLOG): $(GLOG)-build-stamp # when building with clang). # We explicitly build only libglog.la as it is the artifact we depend # on. This e.g., avoids building glog-internal tests. +# +# NOTE: +# On some platforms patch fails to remove test-driver (it is a broken symlink), +# that's why we need to remove it here. +# Also, autogen.sh might be CREATED by the patch and might need its mode fixed. $(GLOG)-build-stamp: $(GLOG)-stamp - cd $(GLOG) && ./configure GTEST_CONFIG=no $(CONFIGURE_ARGS) && \ + cd $(GLOG) &&\ + rm -f test-driver &&\ + chmod a+x ./autogen.sh &&\ + ./autogen.sh && \ Review comment: If we settle with 0.4.0, then rm, chmod and will be unnecessary, as well as the code of autogen.sh in the patch. Running ./autogen.sh is slightly more portable than running autoreconf directly (at least, ./autogen.sh is a part of the intended glog's build pipeline now). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
