asekretenko commented on a change in pull request #327: Updated glog to 0.3.5
and then to 0.4.0, added microseconds to LogSink::send().
URL: https://github.com/apache/mesos/pull/327#discussion_r268630055
##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -379,18 +379,11 @@ if (WIN32)
IMPORTED_IMPLIB ${GLOG_ROOT}-build/glog${CMAKE_IMPORT_LIBRARY_SUFFIX})
endif ()
else ()
- # TODO(andschwa): Build with CMake instead when glog is updated.
- set(GLOG_CONFIG_CMD ${GLOG_ROOT}/src/../configure --with-pic
GTEST_CONFIG=no --prefix=${GLOG_ROOT}-build)
- if (FREEBSD)
- list(APPEND GLOG_CONFIG_CMD LDFLAGS=-lexecinfo)
- endif ()
- set(GLOG_BUILD_CMD ${MAKE_PROGRAM})
- set(GLOG_INSTALL_CMD ${MAKE_PROGRAM} install)
-
set_target_properties(
glog PROPERTIES
- IMPORTED_LOCATION ${GLOG_ROOT}-build/lib/libglog${LIBRARY_SUFFIX}
- INTERFACE_INCLUDE_DIRECTORIES ${GLOG_ROOT}-build/include)
+ INTERFACE_INCLUDE_DIRECTORIES "${GLOG_ROOT}-build;${GLOG_ROOT}/src"
Review comment:
Tried this. To do this properly, I need a good understanding of what is
going on inside the Windows build, as well as an ability to debug the Windows
build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
