----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70404/#review214410 -----------------------------------------------------------
Patch looks great! Reviews applied: [70313, 70314, 70315, 70316, 70331, 70245, 70168, 70247, 70248, 70213, 70214, 70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 70302, 70303, 70321, 70360, 70361, 70362, 70363, 70399, 70400, 70401, 70402, 70403, 70404] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 5, 2019, 6:31 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70404/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 6:31 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9627 > https://issues.apache.org/jira/browse/MESOS-9627 > > > Repository: mesos > > > Description > ------- > > A new `--api_version` optional flag is added to the test CSI plugin. By > default, it will serve both CSI v0 and v1 requests. When this flag is > specified, only one CSI version will be served. > > > Diffs > ----- > > include/mesos/csi/v0.hpp 8be070bcd241d6934f7473c4e56f1992535f76d2 > include/mesos/csi/v1.hpp PRE-CREATION > src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 > > > Diff: https://reviews.apache.org/r/70404/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
