----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70404/#review214464 -----------------------------------------------------------
src/examples/test_csi_plugin.cpp Lines 1095 (patched) <https://reviews.apache.org/r/70404/#comment300669> nit: For readbility ee could create a set of types and add them in a loop. - Benjamin Bannier On April 5, 2019, 8:31 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70404/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 8:31 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9627 > https://issues.apache.org/jira/browse/MESOS-9627 > > > Repository: mesos > > > Description > ------- > > A new `--api_version` optional flag is added to the test CSI plugin. By > default, it will serve both CSI v0 and v1 requests. When this flag is > specified, only one CSI version will be served. > > > Diffs > ----- > > include/mesos/csi/v0.hpp 8be070bcd241d6934f7473c4e56f1992535f76d2 > include/mesos/csi/v1.hpp PRE-CREATION > src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 > > > Diff: https://reviews.apache.org/r/70404/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
