> On April 9, 2019, 9:50 a.m., Benjamin Bannier wrote: > > src/csi/service_manager.cpp > > Lines 360 (patched) > > <https://reviews.apache.org/r/70428/diff/2/?file=2138160#file2138160line360> > > > > Any reason we couldn't return early here if `apiVersion.isSome()`?
A very good point! - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70428/#review214493 ----------------------------------------------------------- On April 9, 2019, 6:08 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70428/ > ----------------------------------------------------------- > > (Updated April 9, 2019, 6:08 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9626 > https://issues.apache.org/jira/browse/MESOS-9626 > > > Repository: mesos > > > Description > ------- > > The `mesos::csi::VolumeManager::create` function now first creates a > `ServiceManager` to detect the API version, then instantiate the proper > `VolumeManager` based on it. > > NOTE: This patch enables CSI v1 by default for all SLRP-related unit > tests except for test `RetryRpcWithExponentialBackoff`. > > > Diffs > ----- > > src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5 > src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0 > src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3 > src/csi/v0_volume_manager.cpp 7de900095bb86c207869c599c17ca08838e722be > src/csi/v0_volume_manager_process.hpp > 88073e423559f1fc5d171dbbac26e46472589e5a > src/csi/v1_volume_manager.hpp PRE-CREATION > src/csi/v1_volume_manager.cpp PRE-CREATION > src/csi/v1_volume_manager_process.hpp PRE-CREATION > src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49 > src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f > src/resource_provider/storage/provider.cpp > 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f > src/tests/storage_local_resource_provider_tests.cpp > da8db41b867d04b4236ad3515811fc00318c619c > > > Diff: https://reviews.apache.org/r/70428/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
