-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70428/
-----------------------------------------------------------
(Updated April 9, 2019, 8:17 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments.
Bugs: MESOS-9626
https://issues.apache.org/jira/browse/MESOS-9626
Repository: mesos
Description
-------
The `mesos::csi::VolumeManager::create` function now first creates a
`ServiceManager` to detect the API version, then instantiate the proper
`VolumeManager` based on it.
NOTE: This patch enables CSI v1 by default for all SLRP-related unit
tests except for test `RetryRpcWithExponentialBackoff`.
Diffs (updated)
-----
src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
src/csi/v0_volume_manager_process.hpp
c3cd6caa0e53bdb19213e1383f458ce7aab9485d
src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
src/csi/v1_volume_manager_process.hpp
1c80399be434781401acda753ed5d69e1dc12a32
src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
src/resource_provider/storage/provider.cpp
2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
src/tests/storage_local_resource_provider_tests.cpp
bd35150200a23ba57408f5d64a975f8a2f062018
Diff: https://reviews.apache.org/r/70428/diff/3/
Changes: https://reviews.apache.org/r/70428/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
