> On April 23, 2019, 10:47 a.m., Benjamin Bannier wrote: > > src/tests/slave_tests.cpp > > Lines 6499 (patched) > > <https://reviews.apache.org/r/70132/diff/5/?file=2140651#file2140651line6499> > > > > Since the changes in this patch are strongly related to behavior > > framework authors need to reason about I strongly feel that we must add a > > test for the expected behavior. > > Chun-Hung Hsiao wrote: > I could add a unit test in a separated patch. This patch itself will be > backported, after discussed with @bmahler.
Done in r/70537. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70132/#review214812 ----------------------------------------------------------- On April 23, 2019, 1:15 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70132/ > ----------------------------------------------------------- > > (Updated April 23, 2019, 1:15 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu. > > > Bugs: MESOS-9616 > https://issues.apache.org/jira/browse/MESOS-9616 > > > Repository: mesos > > > Description > ------- > > Currently if a framework accepts an offer to perform pipelined > operations, e.g., reserving resource, without a final consumer, the > converted resources will be implicitly declined. This is an undesired > behavior as the framework might want to reserve one resource first but > launch a task later in the next allocation cycle. This patch fixes this > behavior. > > But, if the framework accepts an offers with multiple operations that > cancel out each other, the resources consumed by these operations are > still considered unused and will be declined. > > > Diffs > ----- > > docs/scheduler-http-api.md a5327c229142267836f327f9c382ef50b7e334db > src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 > src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559 > > > Diff: https://reviews.apache.org/r/70132/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
