----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review215060 -----------------------------------------------------------
Patch looks great! Reviews applied: [70184] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 6, 2019, 9:48 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70184/ > ----------------------------------------------------------- > > (Updated May 6, 2019, 9:48 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9594 > https://issues.apache.org/jira/browse/MESOS-9594 > > > Repository: mesos > > > Description > ------- > > Under some circumstances, offers would be filtered, resulting in the > test being stuck while waiting for offers. This has been resolved by > settling the clock before accepting new offers. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6 > > > Diff: https://reviews.apache.org/r/70184/diff/2/ > > > Testing > ------- > > make check > > I could not reproduce the flaky behavior of this test case, hence only assume > that this patch resolves the flakiness. > > > Thanks, > > Jan Schlicht > >
