----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/ -----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos Description ------- We were passing callbacks into `MockResourceProvider` to the HTTP driver. Since the lifecycle of the callbacks and the mock provider were decoupled and these callbacks were binding the mock provider instance the code was not safe as written as the driver could invoke the callback after the provider had been destructed. This patch makes sure that the callbacks are defered to a process. We also dispatch a number of other functions which are strongly coupled to the lifecycle of the provider. We still do not hide the provider away completelt so the provider can be mocked in tests. Diffs ----- src/tests/api_tests.cpp 2220cecc22778a86f0c29317adf495927e1a900d src/tests/master_slave_reconciliation_tests.cpp 7b6ac50adacc8416b91c0dde55ff7ba46a20515c src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e src/tests/mesos.hpp d0c82fa4c1800ed2a1825d563a9462ecd41b77fd src/tests/operation_reconciliation_tests.cpp eae318da2273faae904f0155e49bb23cdb24f007 src/tests/resource_provider_manager_tests.cpp 7d48f18e89f046df6c92e52edeef592acfb13b10 src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 Diff: https://reviews.apache.org/r/70728/diff/1/ Testing ------- `make check` Thanks, Benjamin Bannier
