----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215686 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Lines 1842-1845 (patched) <https://reviews.apache.org/r/70738/#comment302485> Move it ahead of the capability check. src/master/allocator/mesos/hierarchical.cpp Lines 1906 (patched) <https://reviews.apache.org/r/70738/#comment302481> Let's save a name: shrinkResources(available.scalars().unreserved().nonRevocable(), unsatisfiedQuotaGuarantees); src/master/allocator/mesos/hierarchical.cpp Line 1900 (original), 1916 (patched) <https://reviews.apache.org/r/70738/#comment302480> Maybe it is better to skip roles with reservations but guarantees satisfied. Instead, allow them to get reservations and burst in the second stage. src/master/allocator/mesos/hierarchical.cpp Line 1910 (original), 1927 (patched) <https://reviews.apache.org/r/70738/#comment302482> Name it `additionalScalarAllocation` src/master/allocator/mesos/hierarchical.cpp Line 1920 (original), 1944 (patched) <https://reviews.apache.org/r/70738/#comment302483> comment on `guaranteesAllocation` getting canceled. Maybe a formula? src/master/allocator/mesos/hierarchical.cpp Lines 1973 (patched) <https://reviews.apache.org/r/70738/#comment302489> `increasedQuotaConsumption` src/master/allocator/mesos/hierarchical.cpp Lines 2046-2049 (original), 2060-2063 (patched) <https://reviews.apache.org/r/70738/#comment302484> Move it ahead of the capability check. src/master/allocator/mesos/hierarchical.cpp Line 2065 (original), 2079 (patched) <https://reviews.apache.org/r/70738/#comment302486> name it `extraScalarAllocation` src/master/allocator/mesos/hierarchical.cpp Lines 2104 (patched) <https://reviews.apache.org/r/70738/#comment302490> We are chopping agents here in the 2nd stage. This is something new. Let's add this to the description. src/master/allocator/mesos/hierarchical.cpp Lines 2129 (patched) <https://reviews.apache.org/r/70738/#comment302488> `increasedQuotaConsumption` src/master/allocator/mesos/hierarchical.cpp Lines 2132-2134 (patched) <https://reviews.apache.org/r/70738/#comment302487> Let's skip roles that have default quota here. And have a follow up patch to enable tracking consumed quota for all roles. This will be useful for exposing role consumed quota. src/tests/hierarchical_allocator_tests.cpp Line 4355 (original), 4355 (patched) <https://reviews.apache.org/r/70738/#comment302491> Split this tests into multiple ones: QuotaAbsentFrameworkWholeAgent QuotaAbsentFrameworkChopAgent - Meng Zhu On June 3, 2019, 9:53 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70738/ > ----------------------------------------------------------- > > (Updated June 3, 2019, 9:53 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-8456 > https://issues.apache.org/jira/browse/MESOS-8456 > > > Repository: mesos > > > Description > ------- > > This patch allows roles to burst above their quota guarantees > up to the quota limits. > > In the first allocation stage which is dedicated to roles > with non-default guarantees, we allow these roles to burst > up to their limits for resources that they have guarantees > set as well as for other resources allocated together > with the guaranteed resources. These bursts are subject to > global headroom enforcement. > > In the second allocation stage, we allow all roles to burst > up to their limits while maintaining the global headroom. > > Also fixed an affected test. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > aa4c43882d0befb2100c92f383e87ab637fa4c7e > src/tests/hierarchical_allocator_tests.cpp > 7221a642a8dda1c7b8ed5ebe7f9b840b5e949e88 > > > Diff: https://reviews.apache.org/r/70738/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
