----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215704 -----------------------------------------------------------
Patch looks great! Reviews applied: [70779, 70780, 70738] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 4, 2019, 9:15 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70738/ > ----------------------------------------------------------- > > (Updated June 4, 2019, 9:15 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-8456 > https://issues.apache.org/jira/browse/MESOS-8456 > > > Repository: mesos > > > Description > ------- > > This patch allows roles to burst above their quota guarantees > up to the quota limits. > > In the first allocation stage which is dedicated to roles > with non-default guarantees, we allow these roles to burst > up to their limits for resources that they have guarantees > set as well as for other resources allocated together > with the guaranteed resources. These bursts are subject to > global headroom enforcement. > > In the second allocation stage, we allow all roles to burst > up to their limits while maintaining the global headroom. > In this stage, if some unreserved non-revocable scalar resources > on the agent need to be held back to maintain the headroom, > we will "chop" them to make the largest offer possible without > breaking the quota headroom. Previously, if any resources are > needed on this agent to maintain the headroom, NO unreserved > scalar resources will be offered at all. > > Also fixed an affected test. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > aa4c43882d0befb2100c92f383e87ab637fa4c7e > src/tests/hierarchical_allocator_tests.cpp > 7221a642a8dda1c7b8ed5ebe7f9b840b5e949e88 > > > Diff: https://reviews.apache.org/r/70738/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
