----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70802/#review215832 -----------------------------------------------------------
src/master/allocator/mesos/metrics.hpp Lines 51 (patched) <https://reviews.apache.org/r/70802/#comment302755> // TODO(mzhu): Remove these ... We don't want to merely deprecate them (i.e. leave them present), we want to remove them right? src/master/allocator/mesos/metrics.cpp Lines 196-198 (patched) <https://reviews.apache.org/r/70802/#comment302756> Hm.. this doesn't seem to fit with the new approach, where we want to always track consumption, allocation, etc. even if quota is the default - Benjamin Mahler On June 7, 2019, 5:24 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70802/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 5:24 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9807 > https://issues.apache.org/jira/browse/MESOS-9807 > > > Repository: mesos > > > Description > ------- > > This intends to replace the existing ``Metrics::setQuota` and > `Metrics::remove` calls. > > Currently, it only tracks guarantees. Need to add limits metrics. > > > Diffs > ----- > > src/master/allocator/mesos/metrics.hpp > a26278ab95aae1fc99ab0afbcfb6dd40651f3a33 > src/master/allocator/mesos/metrics.cpp > 5533eb9910daf90484c255b75b1bcea54b23ba9f > > > Diff: https://reviews.apache.org/r/70802/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
