> On June 11, 2019, 10:05 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/metrics.cpp > > Lines 196-198 (patched) > > <https://reviews.apache.org/r/70802/diff/1/?file=2148073#file2148073line196> > > > > Hm.. this doesn't seem to fit with the new approach, where we want to > > always track consumption, allocation, etc. even if quota is the default
Right, this patch is just a refactoring where the old behavior is preserved. I plan to tackle it in another ticket/patch to expose the consumption. Probably under a different metrics name, not `offered_or_allocated`. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70802/#review215832 ----------------------------------------------------------- On June 6, 2019, 10:24 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70802/ > ----------------------------------------------------------- > > (Updated June 6, 2019, 10:24 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9807 > https://issues.apache.org/jira/browse/MESOS-9807 > > > Repository: mesos > > > Description > ------- > > This intends to replace the existing ``Metrics::setQuota` and > `Metrics::remove` calls. > > Currently, it only tracks guarantees. Need to add limits metrics. > > > Diffs > ----- > > src/master/allocator/mesos/metrics.hpp > a26278ab95aae1fc99ab0afbcfb6dd40651f3a33 > src/master/allocator/mesos/metrics.cpp > 5533eb9910daf90484c255b75b1bcea54b23ba9f > > > Diff: https://reviews.apache.org/r/70802/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
