----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70798/#review216026 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 52 (patched) <https://reviews.apache.org/r/70798/#comment302982> consider to move it to containerizer/mesos/path.hpp? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 52-54 (patched) <https://reviews.apache.org/r/70798/#comment302987> consider to return Result<string> for no parent case? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 56 (patched) <https://reviews.apache.org/r/70798/#comment302986> a bit confusing. the parentId could be assigned as a containerId without a parent? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 90-93 (patched) <https://reviews.apache.org/r/70798/#comment302985> what if for SHARE_PARENT case but the container does not have a parent? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 137-143 (patched) <https://reviews.apache.org/r/70798/#comment302988> is this a new dependency? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 212 (patched) <https://reviews.apache.org/r/70798/#comment302989> are we going to remove the `createContainerMount()` in linux filesystem isolator? src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Line 94 (original), 382 (patched) <https://reviews.apache.org/r/70798/#comment302990> if we introduce cleanup(), does it mean we could avoid the dependency on linux filesystem isolator? src/slave/containerizer/mesos/paths.hpp Lines 85 (patched) <https://reviews.apache.org/r/70798/#comment302978> how about `CONTAINER_SHM_DIRECTORY` or just `CONTAINER_SHM`? - Gilbert Song On June 11, 2019, 7:33 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70798/ > ----------------------------------------------------------- > > (Updated June 11, 2019, 7:33 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > ------- > > Improved `namespaces/ipc` isolator for configurable IPC support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp > 32c888309ca536d944e4d73641aed214805ccce2 > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7 > src/slave/containerizer/mesos/paths.hpp > a5e0920bd4d753f6ba6f3b092c92cb405e9edf35 > src/slave/containerizer/mesos/paths.cpp > 4281abc522c942c87fcfd811af26f95cbd6f734f > src/tests/containerizer/isolator_tests.cpp > 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 > > > Diff: https://reviews.apache.org/r/70798/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
