----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70798/#review216548 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 190-192 (patched) <https://reviews.apache.org/r/70798/#comment303761> nits: ``` containerConfig.has_rootfs() ? path::join(containerConfig.rootfs(), "/dev/shm") : "/dev/shm", ``` src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp Lines 220-222 (patched) <https://reviews.apache.org/r/70798/#comment303762> ditto - Gilbert Song On June 29, 2019, 7:10 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70798/ > ----------------------------------------------------------- > > (Updated June 29, 2019, 7:10 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > ------- > > Improved `namespaces/ipc` isolator for configurable IPC support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp > 32c888309ca536d944e4d73641aed214805ccce2 > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7 > src/slave/containerizer/mesos/paths.hpp > a5e0920bd4d753f6ba6f3b092c92cb405e9edf35 > src/slave/containerizer/mesos/paths.cpp > 4281abc522c942c87fcfd811af26f95cbd6f734f > src/tests/containerizer/isolator_tests.cpp > 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 > > > Diff: https://reviews.apache.org/r/70798/diff/5/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
