> On June 14, 2019, 9:59 a.m., Benjamin Bannier wrote: > > src/tests/slave_tests.cpp > > Lines 11785-11786 (patched) > > <https://reviews.apache.org/r/70836/diff/1/?file=2148632#file2148632line11785> > > > > Do we want to add e.g., tasks into this test later? As written it would > > fit better into the API tests (though they have pretty bad scope creep). > > Greg Mann wrote: > Yea I'm not sure how this test will evolve as the master-side > functionality is added; it's possible that we will want to move the API > verification from this test into another one. I didn't put it in the API > tests because the AgentAPITest fixture is parametrized by content type for v1 > API requests, and since this tests both v0 and v1 API outputs, it seemed like > an awkward fit?
I think it's OK to merge this test as-is for now, and update or erase as appropriate when the master-side code is merged. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70836/#review215897 ----------------------------------------------------------- On June 25, 2019, 8 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70836/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 8 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and > Joseph Wu. > > > Bugs: MESOS-9818 > https://issues.apache.org/jira/browse/MESOS-9818 > > > Repository: mesos > > > Description > ------- > > Added test for DrainConfig in agent API outputs. > > > Diffs > ----- > > src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 > > > Diff: https://reviews.apache.org/r/70836/diff/3/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh --gtest_filter="*DrainInfoInAPIOutputs*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
