----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70836/#review216189 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 11871 (patched) <https://reviews.apache.org/r/70836/#comment303263> It would probably be fine to get rid of this temporary if we'd `s/parse/state/g` and used `state->values` below. - Benjamin Bannier On June 25, 2019, 10 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70836/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 10 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and > Joseph Wu. > > > Bugs: MESOS-9818 > https://issues.apache.org/jira/browse/MESOS-9818 > > > Repository: mesos > > > Description > ------- > > Added test for DrainConfig in agent API outputs. > > > Diffs > ----- > > src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 > > > Diff: https://reviews.apache.org/r/70836/diff/3/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh --gtest_filter="*DrainInfoInAPIOutputs*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
