----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70950/#review216157 -----------------------------------------------------------
Can you also expand the commit description with a more precise comment about how these two fields will be used? src/master/registry.proto Lines 136-139 (original), 136-147 (patched) <https://reviews.apache.org/r/70950/#comment303197> Ditto comment from the last review. After discussing this offline and understanding the overall approach, it's clear that someone looking at these two fields will not understand the overall approach taken. Can you add a guiding comment here about these two fields? Might as well group them together: ``` // GUIDING COMMENT repeated Quota quotas = 5 [deprecated = true]; repeated quota.QuotaConfig quota_configs = 11; ``` src/master/registry.proto Lines 140-141 (patched) <https://reviews.apache.org/r/70950/#comment303195> Can you file a ticket that tracks this removal for the 2.0 timeframe and link it here? - Benjamin Mahler On June 26, 2019, 1:37 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70950/ > ----------------------------------------------------------- > > (Updated June 26, 2019, 1:37 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9601 > https://issues.apache.org/jira/browse/MESOS-9601 > > > Repository: mesos > > > Description > ------- > > A new field called `quota_configs` is added to persist the > quota configurations of the cluster. This replaces the old > `quotas` field which is deprecated and will be removed > in Mesos 2.0. > > > Diffs > ----- > > src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685 > > > Diff: https://reviews.apache.org/r/70950/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
