----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70950/#review216205 -----------------------------------------------------------
Ship it! src/master/registry.proto Lines 136-138 (original), 136-138 (patched) <https://reviews.apache.org/r/70950/#comment303292> not yours, but strange comment.. src/master/registry.proto Lines 140-152 (patched) <https://reviews.apache.org/r/70950/#comment303291> thanks! src/master/registry.proto Lines 154 (patched) <https://reviews.apache.org/r/70950/#comment303290> thanks for the ticket! - Benjamin Mahler On June 26, 2019, 1:37 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70950/ > ----------------------------------------------------------- > > (Updated June 26, 2019, 1:37 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9601 > https://issues.apache.org/jira/browse/MESOS-9601 > > > Repository: mesos > > > Description > ------- > > A new field called `quota_configs` is added to persist the > quota configurations of the cluster. This replaces the old > `quotas` field which is deprecated and will be removed > in Mesos 2.0. > > When users upgrade to Mesos 1.9, `quotas` will be preserved > and recovered and `quota_configs` will be empty. As users > configures new quotas, whether through the new `UPDATE_QUOTA` > call or the deprecated `SET_QUTOA` call, the configured quotas > will be persisted into the `quota_configs` field along with the > `QUOTA_V2` minimum capability. The capability is removed only > if `quota_configs` becomes empty again. If a role already has an > entry in the old `quotas` field, it will be removed from `quotas`. > In other words, once upgraded, `quotas` will still be preserved > and honored, but it will never grow. Instead it will gradually > shrink as the roles' quotas get updated or removed. > > > Diffs > ----- > > src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685 > > > Diff: https://reviews.apache.org/r/70950/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
