> On June 26, 2019, 12:18 p.m., Benjamin Mahler wrote: > > Ditto comment below w.r.t. the description, can you make the description > > more precise about the overall approach with this minimum capability and > > the registry?
Done. > On June 26, 2019, 12:18 p.m., Benjamin Mahler wrote: > > src/master/constants.cpp > > Lines 28 (patched) > > <https://reviews.apache.org/r/70949/diff/2/?file=2152267#file2152267line28> > > > > Is the master v2 quota capable yet in this patch? > > > > I guess the agent doesn't care about this capability, but it seems > > nicer if we add it after the master can actually handle v2 style quota > > requests? I think the `QUOTA_V2` here is essentially the ability to decode/recover from the quota registry. From this regard, the master gets that ability from this very patch. But to answer your question, no, the master at the moment can't handle the `UPDATE_QUOTA` call. (But handle the call requires the registry change, right :)) Anyway, I am OK with postponing the patch and commit it when we wire up the call. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70949/#review216156 ----------------------------------------------------------- On June 25, 2019, 10:58 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70949/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 10:58 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9601 > https://issues.apache.org/jira/browse/MESOS-9601 > > > Repository: mesos > > > Description > ------- > > This adds a new enum for the revamped quota feature > in the master. When quota is configured in Mesos 1.9 > or higher, the `QUOTA_V2` minimum capability will be > persisted into the registry. This will prevent any master > downgrades until all quotas configured in Mesos 1.9 or higher > are set back to the default (no guarantees and no limits). > > > Diffs > ----- > > docs/downgrades.md 3807254143d19f36079498c1a01adf744e21e8a2 > include/mesos/mesos.proto d2750a634bf58428a152e70aedfc06ff70b3aa84 > src/common/protobuf_utils.hpp f6ea9230d38079b24060922872ee93d9f038b98e > src/master/constants.cpp 13b3467825c624fd3cb1652fbfec1a9631ca37e6 > src/tests/master_tests.cpp d7b4613980cb13d2009426b3a07690aac659cda7 > > > Diff: https://reviews.apache.org/r/70949/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
