----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70949/#review216204 -----------------------------------------------------------
Fix it, then Ship it! I gave a ship it assuming we just add the protobuf and documentation, but we don't yet set this capability on the master (see below). src/master/constants.cpp Lines 28 (patched) <https://reviews.apache.org/r/70949/#comment303289> How about we commit this patch without this line (and the test expectation below)? That way, we can get the capability and documentation for it in, but we don't yet add this capability until the new API is wired up? - Benjamin Mahler On June 27, 2019, 4:24 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70949/ > ----------------------------------------------------------- > > (Updated June 27, 2019, 4:24 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9601 > https://issues.apache.org/jira/browse/MESOS-9601 > > > Repository: mesos > > > Description > ------- > > This adds a new enum for the revamped quota feature > in the master. When quota is configured in Mesos 1.9 > or higher, the quota configurations will be persisted > into the `quota_configs` field in the registry. And > the `QUOTA_V2` minimum capability will be added to the > registry as well. This will prevent any master downgrades > until `quota_configs` becomes empty. This can be done by > setting the quota of the roles listed in `quota_configs` > back to the default (no guarantees and no limits). > > > Diffs > ----- > > docs/downgrades.md 3807254143d19f36079498c1a01adf744e21e8a2 > include/mesos/mesos.proto eb1b09cf9f9c7c102d713170538c2ba210edb351 > src/common/protobuf_utils.hpp f6ea9230d38079b24060922872ee93d9f038b98e > src/master/constants.cpp 13b3467825c624fd3cb1652fbfec1a9631ca37e6 > src/tests/master_tests.cpp d7b4613980cb13d2009426b3a07690aac659cda7 > > > Diff: https://reviews.apache.org/r/70949/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
