----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71047/#review216493 -----------------------------------------------------------
Unsuppressing upon registering seems reasonable, but the suppress/revive upon TASK_FINISHED seems strange. src/examples/java/TestFramework.java Lines 53 (patched) <https://reviews.apache.org/r/71047/#comment303722> Let's just clear the suppressed roles? It looks like there's no actual assertion that the name change took place? Whereas the unsuppression is needed to get offers and launch the tasks. src/examples/java/TestFramework.java Lines 150-153 (patched) <https://reviews.apache.org/r/71047/#comment303723> This is strange, and is it even going to fail the test if these calls don't take effect properly? - Benjamin Mahler On July 10, 2019, 1:16 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71047/ > ----------------------------------------------------------- > > (Updated July 10, 2019, 1:16 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9849 > https://issues.apache.org/jira/browse/MESOS-9849 > > > Repository: mesos > > > Description > ------- > > This patch adds exercising per-role suppress/revival to the Java test > framework to ensure that passing the corresponding arguments through the > Java bindings works. > > > Diffs > ----- > > src/examples/java/TestFramework.java > c8b0ceacd1305f7ff67f2ef490e14513d2757f5a > > > Diff: https://reviews.apache.org/r/71047/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
