> On July 24, 2019, 3:18 p.m., Benjamin Mahler wrote: > > The batching seems like a divergence from test_framework.py (and we'd > > ideally like those to be consistent), or have the java and python test > > frameworks already diverged? Reading through them quickly now, they seem > > nearly the same except at some point we added some testing of binary data > > in status updates to the python test framework (since it was broken and > > subsequently fixed). > > > > Could we keep them in sync? Either with the current approach from your > > recent test_framework.py patch, or with the batching approach in both. > > Personally, I think just keeping it simple and having an unsuppression > > during registration is enough. If we aren't ok with the manual testing for > > regression purposes, we can always add another test framework for both > > java/python that's more tailored towards suppression / unsuppression rather > > than trying to fit it all into the existing test.
Agreed, it's an example framework, after all, and this is becoming a bit too much for one example. Removed suppressOffers()/revivieOffers() pair. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71047/#review216832 ----------------------------------------------------------- On July 26, 2019, 7:34 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71047/ > ----------------------------------------------------------- > > (Updated July 26, 2019, 7:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9849 > https://issues.apache.org/jira/browse/MESOS-9849 > > > Repository: mesos > > > Description > ------- > > This patch ensures that the list of suppressed roles is passed through > the `updateFramework()` of Java V0 bindings. Now the framework > subscribes with all roles suppressed and after that issues > UPDATE_FRAMEWORK call to unsuppress offers. > > > Diffs > ----- > > src/examples/java/TestFramework.java > c8b0ceacd1305f7ff67f2ef490e14513d2757f5a > > > Diff: https://reviews.apache.org/r/71047/diff/4/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" > --gtest_break_on_failure --gtest_repeat=5 --verbose` > > > Thanks, > > Andrei Sekretenko > >
