----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71050/#review216513 -----------------------------------------------------------
src/master/master.hpp Lines 2800-2801 (patched) <https://reviews.apache.org/r/71050/#comment303731> hmm, what if reservation has non-scalar resources? I guess in all cases, we are just showing scalar ones. But if role `dev` has a reservation of 100 ports, when they hit `/roles`, they will get `reserved : {}`, feels somewhat inappropriate. - Meng Zhu On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71050/ > ----------------------------------------------------------- > > (Updated July 10, 2019, 5:17 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-8789 > https://issues.apache.org/jira/browse/MESOS-8789 > > > Repository: mesos > > > Description > ------- > > This provides a breakdown of resource quantities on a per-role > basis, that would aid debugging if shown in the endpoints and > roles table in the ui. > > > Diffs > ----- > > src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7 > > > Diff: https://reviews.apache.org/r/71050/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
