> On July 11, 2019, 12:48 p.m., Andrei Sekretenko wrote: > > src/master/master.hpp > > Lines 2786 (patched) > > <https://reviews.apache.org/r/71050/diff/1/?file=2154330#file2154330line2786> > > > > Is there a reason why these three methods have no `const` specifier? > > Are they different from `consumedQuota()` and > > `allocatedAndOfferedResources` in regard to const-ness in some non-obvious > > way?
Ah thanks for catching that! Will add const - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71050/#review216521 ----------------------------------------------------------- On July 11, 2019, 12:17 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71050/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 12:17 a.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-8789 > https://issues.apache.org/jira/browse/MESOS-8789 > > > Repository: mesos > > > Description > ------- > > This provides a breakdown of resource quantities on a per-role > basis, that would aid debugging if shown in the endpoints and > roles table in the ui. > > > Diffs > ----- > > src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7 > > > Diff: https://reviews.apache.org/r/71050/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
