-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71008/
-----------------------------------------------------------
(Updated July 11, 2019, 4:01 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and
Vinod Kone.
Changes
-------
Fixed two cases where the agent would not be transitioned to DRAINED:
* When an agent is already technically DRAINED before draining.
* When an agent is already technically DRAINED and unreachable, starts
draining, and then reregisters.
Bugs: MESOS-9814
https://issues.apache.org/jira/browse/MESOS-9814
Repository: mesos
Description
-------
This adds logic in the master to detect when a DRAINING agent can
be transitioned into a DRAINED state. When this happens, the new
state is checkpointed into the registry and, if the agent is to be
marked "gone", the master will remove the agent.
Diffs (updated)
-----
src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c
src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8
src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742
Diff: https://reviews.apache.org/r/71008/diff/4/
Changes: https://reviews.apache.org/r/71008/diff/3-4/
Testing
-------
TODO: Need to write some unit tests. I'll want to rebase onto the agent
changes so that there is more detectable stuff in the tests.
Thanks,
Joseph Wu
