----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/#review216626 -----------------------------------------------------------
src/master/master.cpp Lines 6271 (patched) <https://reviews.apache.org/r/71008/#comment303836> Hmm.. won't this violate the check in `Master::markGone()`: ``` CHECK(slaves.markingGone.contains(slaveId)); ``` - Greg Mann On July 15, 2019, 6:19 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71008/ > ----------------------------------------------------------- > > (Updated July 15, 2019, 6:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds logic in the master to detect when a DRAINING agent can > be transitioned into a DRAINED state. When this happens, the new > state is checkpointed into the registry and, if the agent is to be > marked "gone", the master will remove the agent. > > > Diffs > ----- > > src/master/http.cpp cd0f40cb7b966d6620e3fb49d4c08807185c9101 > src/master/master.hpp e8def83fe9bcee19772df9a9764852bc694c5247 > src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 > > > Diff: https://reviews.apache.org/r/71008/diff/5/ > > > Testing > ------- > > See: https://reviews.apache.org/r/71069/ > > > Thanks, > > Joseph Wu > >
