----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71272/#review217156 -----------------------------------------------------------
Patch looks great! Reviews applied: [71272] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 12, 2019, 1:50 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71272/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2019, 1:50 p.m.) > > > Review request for mesos, Andrei Budnik and Chun-Hung Hsiao. > > > Bugs: MESOS-9560 > https://issues.apache.org/jira/browse/MESOS-9560 > > > Repository: mesos > > > Description > ------- > > When invoking member functions of the mock resource provider > `TestResourceProviderProcess` from default mock actions we need to > ensure that the mock object remains alive for the duration of the > invocation. > > This patch replaces direct invocations which might run on any thread > (e.g., also while the mock object is being destructed on another thread) > which safe `dispatch`es of the default methods. > > > Diffs > ----- > > src/tests/mesos.hpp 73b6e424e8f611cf72f102fa13a6773e2865ddbf > > > Diff: https://reviews.apache.org/r/71272/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
