----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71272/#review217178 -----------------------------------------------------------
Ship it! Ship It! - Andrei Budnik On Авг. 13, 2019, 9:30 д.п., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71272/ > ----------------------------------------------------------- > > (Updated Авг. 13, 2019, 9:30 д.п.) > > > Review request for mesos, Andrei Budnik and Chun-Hung Hsiao. > > > Bugs: MESOS-9560 > https://issues.apache.org/jira/browse/MESOS-9560 > > > Repository: mesos > > > Description > ------- > > When invoking member functions of the mock resource provider > `TestResourceProviderProcess` from default mock actions we need to > ensure that the mock object remains alive for the duration of the > invocation. > > This patch replaces direct invocations which might run on any thread > (e.g., also while the mock object is being destructed on another thread) > which safe `dispatch`es of the default methods. > > > Diffs > ----- > > src/tests/api_tests.cpp c2099674e742eaa08134c5e0a7cdab1734808119 > src/tests/mesos.hpp 73b6e424e8f611cf72f102fa13a6773e2865ddbf > src/tests/resource_provider_manager_tests.cpp > 2792000d291a7d8cd7eeac556c16ccbeb55ed429 > src/tests/slave_tests.cpp 7c6e1d927fefde3f1ecadab1a32c9dd793e70b7f > > > Diff: https://reviews.apache.org/r/71272/diff/2/ > > > Testing > ------- > > `make check` > > For a before/after failure rate breakdown see > https://reviews.apache.org/r/71277/. > > > Thanks, > > Benjamin Bannier > >
